Uploaded image for project: 'CloverDX'
  1. CloverDX
  2. CLO-17590

Worker has redundant property worker.ssl.enabled on command line

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: rel-5-7-0
    • Component/s: Worker
    • Security Level: Users (General product issues)
    • QA Testing:
      UNDECIDED

      Description

      Property worker.ssl.enabled (boolean) directs the Core to turn SSL in Worker process on or off.

      • If set to true, Core selects the TCP port for secure SSL communication and puts it on Worker process command line.
      • If set to false, nothing is put to command line.

      But the Core also puts the "parent" property worker.ssl.enabled=true on command line.

      There is this code in Core:

      		if (workerConfig.getSslPort() > 0) {
      			command.add("-D" + WORKER_SSL_ENABLED + "=true");
      			command.add("-D" + WORKER_SSL_PORT + "=" + workerConfig.getSslPort());
      

      Port is already prepared, because Core previously saw the worker.ssl.enabled=true. Here it is put as a static string (not even taking the actual property value) on command line.

      However, Worker Application can decide that the SSL is turned on by the presence of worker.ssl.port. The other property is redundant.

       

        Attachments

          Activity

            People

            Assignee:
            horskyt Tomas Horsky
            Reporter:
            horskyt Tomas Horsky
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: